Remove lstrip in each OAuth endpoint#770
Closed
hongkunyoo wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
Remove lstrip in each OAuth endpoint#770hongkunyoo wants to merge 1 commit intomodelcontextprotocol:mainfrom
lstrip in each OAuth endpoint#770hongkunyoo wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
`lstrip` strips left `/` which results in `ISSUER_URLauthorize`
Member
|
Right, this is half of what is needed. We need to |
9 tasks
Contributor
|
Hey @hongkunyoo, thank you for setting this up! I also bumped into this issue, great job 🙌 I tested your solution for URLs like |
Author
|
Closing this PR since better proposal exists: #779 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lstripstrips left/which results inISSUER_URLauthorizeMotivation and Context
/.well-known/oauth-authorization-serveroutput is weirld."authorization_endpoint": "https://$MY_ISSUER/authorize","authorization_endpoint": "https://$MY_ISSUERauthorize",It seems
lstripis unnecessary for each OAuth endpointHow Has This Been Tested?
Check following result:
Breaking Changes
No
Types of changes
Checklist
Additional context